Closed mbtaylor closed 4 months ago
Hi @mbtaylor ,
Thank you for the report.
The good news is that the rust library seems to be working well for both polygons.
See the screenshot made in Aladin:
I am going to check the differences between both libraries to fix the Java one (today or tomorrow).
fx
Fixed in commit b6880155961430bc2e97dd3d308f1d1f160703cc (if the Newton method fails, we are in a corner case which probably does not contains "special points"; if we found a corner case having a special point we could fallback with a dichotomic appoach).
Thanks @fxpineau, I confirm that fixes my test case and the application issue I encountered that led to the report. Will you assign a new release number/tag to this version?
Sure. I just updated the CHANGES file, the version number and added a tag. Thank you @mbtaylor .
Thanks!
Hi @fxpineau. I see a problem if I run the following code against cds-healpix-java v0.30.2:
The calculation with the second set of vertices gives me an
AssertionError
atcds.healpix.NewtonMethod.arcSpecialPointInEqr(NewtonMethod.java:234)
, or aNullPointerException
later on if assertions are turned off. This is probably some kind of edge case since this code has been in topcat for several years and I haven't noticed it before now.