search

cds-astro / ipyaladin

An IPython Widget for Aladin Lite, the sky viewer.
https://cds-astro.github.io/ipyaladin/
BSD 3-Clause "New" or "Revised" License
126 stars 26 forks source link

requests became mandatory with planetary name support #117

Closed ManonMarchand closed 2 weeks ago

ManonMarchand commented 3 weeks ago

We have to make it optional or add it officially in our dependencies, see failure of conda forge package https://dev.azure.com/conda-forge/feedstock-builds/_build/results?buildId=1031951&view=logs&j=656edd35-690f-5c53-9ba3-09c10d0bea97&t=e5c8ab1d-8ff9-5cae-b332-e15ae582ed2d

https://github.com/conda-forge/ipyaladin-feedstock/pull/16

TODO : add CI without optional dependencies

tboch commented 3 weeks ago

Well, we could also remove requests dependency and replace the code with urllib.request calls.

Having an additional dependency just for this feels weird to me.