search

cds-astro / ipyaladin

An IPython Widget for Aladin Lite, the sky viewer.
https://cds-astro.github.io/ipyaladin/
BSD 3-Clause "New" or "Revised" License
126 stars 26 forks source link

Make ipyaladin running in JupyterLab #4

Closed tboch closed 1 year ago

tboch commented 6 years ago

This is developed in branch https://github.com/cds-astro/ipyaladin/tree/jupyterlab-support

cdeil commented 6 years ago

I tried with latest master (aa009c6d88ccfd2d25ea9d2b08c9dda201b9f55a) and got this error: https://gist.github.com/cdeil/8d350e3e830b870c6af795814fa57369#file-gistfile1-txt-L159

Is this something you have to fix, or is my JupyterLab too old or some other issue on my side?

athornton commented 5 years ago

Is there any plan to release the JL extension as an NPM package, so we can just install it from npm rather than having to do a source build ? If not...what needs to be done to make that happen?

tboch commented 5 years ago

@athornton : ipyaladin can be pip-installed. I'm not sure I understand your need, could you elaborate?

athornton commented 5 years ago

From the README:

To enable ipyaladin in JupyterLab:

$ git clone https://github.com/cds-astro/ipyaladin
$ cd ipyaladin/js
$ jupyter labextension install

It would be nice if I could get this without cloning the package, by having the lab extension published to npm as something like @cds-astro/ipyaladin-jupyterlabextension, so I can just jupyter labextension install it straight from npm.

athornton commented 5 years ago

Is that sufficient elaboration?

tboch commented 5 years ago

yes, thank you @athornton , that's perfectly clear and I think that's a good idea.

Will do it.

athornton commented 5 years ago

Just bumping this issue, since AFAIK the extension has not been published to npm.

athornton commented 5 years ago

Bumping again.

athornton commented 5 years ago

And again, now that JupyterLab 1.0 is released.

bmatthieu3 commented 1 year ago

ipyaladin is much more supported inside jupyterlab from version 0.1.11. I close that issue. If you still experience problem, do not hesitate to reopen one.