Development install instructions slightly incorrect

cds-astro / ipyaladin

An IPython Widget for Aladin Lite, the sky viewer.

https://cds-astro.github.io/ipyaladin/

BSD 3-Clause "New" or "Revised" License

126 stars 26 forks source link

Development install instructions slightly incorrect #48

Closed jbrinchmann closed 1 year ago

jbrinchmann commented 1 year ago

Hi,

I was trying to install following the development install instructions in the README, but I realised that this omits building the Javascript library so in the end I got several errors. Comparing to the compile.sh script, it seems that

cd js
npm install
cd ..

is missing. With those commands everything seems to be working.

ManonMarchand commented 1 year ago

Hello! Thanks for spotting that, we'll change the instructions

ManonMarchand commented 1 year ago

Will be fixed with next release (see PR opened on dev branch)