search

cds-astro / ipyaladin

An IPython Widget for Aladin Lite, the sky viewer.
https://cds-astro.github.io/ipyaladin/
BSD 3-Clause "New" or "Revised" License
126 stars 26 forks source link

ipyaladin 0.2.3 add_listener issue #67

Closed RobinMeneust closed 1 year ago

RobinMeneust commented 1 year ago

The click event doesn't seem to work in ver. 0.2.3, but it does in ver. 0.2.0.

In ver. 0.2.0, I get the following info box, but in ver. 0.2.3 the info box content remains empty image

Notebook: https://github.com/cds-astro/ipyaladin/blob/master/examples/7_on-click-callback.ipynb Environment: Python 3.10.6 and modules in requirements.txt

ManonMarchand commented 1 year ago

You're right. Thanks a lot for spotting this bug!

For reference during investivation:

Console error when using the listenner : 

Uncaught TypeError: this is undefined
    model_events jupyter-aladin.js:263
    r aladin.js:2
    dispatch aladin.js:2
    handle aladin.js:2
ManonMarchand commented 1 year ago

It should be fixed with the version 0.2.4 that we just released. Don't hesitate to open an other issue if you find anything sketchy. Thanks again!