Merge global refactoring to Master - Githubissues

cds-astro / ipyaladin

An IPython Widget for Aladin Lite, the sky viewer.

https://cds-astro.github.io/ipyaladin/

BSD 3-Clause "New" or "Revised" License

126 stars 26 forks source link

Merge global refactoring to Master #82

Closed Xen0Xys closed 5 months ago

Xen0Xys commented 5 months ago

The objective of this PR is to suggest a way to refactor the project and mainly the Javascript part with some improvements :

[x] Splitting into multiple functions and objects
[x] Uniform naming conventions
[x] Optional and needed dependencies for Python (like mocpy)
[x] Improvement to some Python functions (like add_table)
[x] Uniformed documentation with jsdoc and docstring
[x] Minimal supported python version in pyproject.toml
[x] Change add_listener function to set_listener in Python
[x] #77

ManonMarchand commented 5 months ago

Maybe we could run the tests for the oldest and newest python versions that are supported ? (3.8 and 3.12)

ManonMarchand commented 5 months ago

Fixes #77

Xen0Xys commented 5 months ago

Do not merge until the recursion bug isn't fixed !