feedback + card.uuid - first take

isaacvetter commented 4 years ago

Per: https://github.com/cds-hooks/docs/wiki/Feedback-endpoint-for-CDS-Hooks-1.1

yashaskram commented 4 years ago

I am assuming dismiss is same as overrideReasons https://cds-hooks.org/specification/current/#overridereason and this PR will be updated to reflect the same?
Is security expectation for the /feedback endpoint is same as https://cds-hooks.org/specification/current/#trusting-cds-clients?

isaacvetter commented 4 years ago

Hey @yashaskram,

Thanks for the review!

I am assuming dismiss is same as overrideReasons https://cds-hooks.org/specification/current/#overridereason and this PR will be updated to reflect the same?

I went back and forth a bunch of times on the actual words (overridden vs dismiss vs acknowledge), but intended to settle on the word override. I don't see where I'm using the word dismiss, except in the human-facing, descriptive explanation of the functionality. What am I missing?

Is security expectation for the /feedback endpoint is same as https://cds-hooks.org/specification/current/#trusting-cds-clients?

Ah, that's a great point. Yes, exactly. I added a sentence to make this more explicit. Any concerns?

jmandel commented 4 years ago

I'd also like to see a full example of a feedback request, crafted to go along with https://cds-hooks.org/specification/current/#example_1

isaacvetter commented 4 years ago

@dennispatterson - one more look? I think I fixed your issues (great review, btw!)

cds-hooks / docs

feedback + card.uuid - first take #519