cds-snc / c19-benefits-node

Answer some questions to find which federal programs can help you https://covid-benefits.alpha.canada.ca/. - Répondez à quelques questions pour trouver quels programmes d’aide financière fédéraux s’offrent à vous https://covid-prestations.alpha.canada.ca/.
MIT License
2 stars 4 forks source link

Translate results query string. #366

Closed CalvinRodo closed 4 years ago

CalvinRodo commented 4 years ago

To comply with the spirit of the Directive on Official Languages for Communications and Services we should translate our query strings on the results page when the language switches.

At the moment we do comply with the directive since it only mentions the Domain.

https://www.tbs-sct.gc.ca/pol/doc-eng.aspx?id=26164#sec6.6

dsamojlenko commented 4 years ago

yeah, this would not be an easy lift - since we're just loading the whole data attribute to the url, we would need to somehow translate all of our variable names and radio value attributes.

I am pretty sure querystrings aren't covered under this. If they are, then I'd suggest doing without the bookmarking feature, as I don't think it would be worth the effort, at least in its current form.

I suppose we could look at somehow hashing the entire querystring, then putting that up on the url as a workaround.