cds-snc / covid-alert-server

Exposure Notification: Diagnosis Server implementation / Notification d’exposition : Mise en œuvre du serveur de diagnostic
Apache License 2.0
298 stars 31 forks source link

S3 bucket content checks #275

Closed maxneuvians closed 4 years ago

maxneuvians commented 4 years ago

Fixes: #267

Description of what your PR accomplishes:

Adds Route53 health checks to the static content served up by the S3 buckets. AWS has canaries that can do this, however, they do not exist in terraform yet. The drawback of Route53 checks is that they run every 30 seconds and from multiple regions, which will increase the traffic to those endpoints. However, the tradeoff is not significant enough to remove these from Terraform.

Why this approach? Any notable design decisions?

The code limits the regions from the maximum eight to the minimum three from which health checks are run.

Anything the reviewers should focus on? Any discussion points?