cds-snc / covid-alert-server

Exposure Notification: Diagnosis Server implementation / Notification d’exposition : Mise en œuvre du serveur de diagnostic
Apache License 2.0
298 stars 31 forks source link

Remove transactions from db.saveEvent #378

Closed CalvinRodo closed 3 years ago

CalvinRodo commented 3 years ago

Description

The private method persistence.saveEvent should not run in a transaction since it's usually run from within a transaction because transactions cannot be nested in MySQL, so either we are commiting too early or golang is just ignore the nest.

The public method persistence.SaveEvent should have the transaction instead.

AC

CalvinRodo commented 3 years ago

Was done