cds-snc / covid-alert-server

Exposure Notification: Diagnosis Server implementation / Notification d’exposition : Mise en œuvre du serveur de diagnostic
Apache License 2.0
298 stars 31 forks source link

Investigate OTK Duration irregularity #427

Closed CalvinRodo closed 3 years ago

CalvinRodo commented 3 years ago

OTK Durations are only showing one bucket per day, while at first this was not cause for concern we now think there may be a bug where everything is getting bucketed into the longest duration per day instead of bucketed in the proper hour.

CalvinRodo commented 3 years ago

Bug found - OTK Durations where using Date & Originator as the unique ID for the table instead of Hours & Originator.

Unfortunately this reduces the value of the data previously collected, we still gain value from knowing that most OTKs were claimed within a single hour but we lose the granularity we would like for this metric so we will keep old data for historical purposes only.

Will be fixed in #428