This PR changes all the short shas in the deploy-containers.yml file to the equivalent long shas.
It also converts the two actions into a single matrixed action as they were simply copied and pasted versions of each other
Why this approach? Any notable design decisions?
The assumption is that with Github recently dropping support of pinning actions to short SHAs that the actions defaulted to a newer version of the actions that we tried to pin. Potentially this introduced a bug in the current version of the aws-actions/amazon-ecs-deploy-task-definition action.
I opted not to upgrade to newer versions of the action in order to minimize the number of changes to this PR, but will upgrade in a later PR.
Anything the reviewers should focus on? Any discussion points?
Make sure the yaml is fine, we unfortunately won't be able to know if this fixes things unless we merge to master.
Fixes:
A bug where deploys to staging aren't occurring.
See the following error: https://github.com/cds-snc/covid-alert-server/actions/runs/519104768
Description of what your PR accomplishes:
This PR changes all the short shas in the
deploy-containers.ymlfile to the equivalent long shas. It also converts the two actions into a single matrixed action as they were simply copied and pasted versions of each otherWhy this approach? Any notable design decisions?
The assumption is that with Github recently dropping support of pinning actions to short SHAs that the actions defaulted to a newer version of the actions that we tried to pin. Potentially this introduced a bug in the current version of the aws-actions/amazon-ecs-deploy-task-definition action.
I opted not to upgrade to newer versions of the action in order to minimize the number of changes to this PR, but will upgrade in a later PR.
Anything the reviewers should focus on? Any discussion points?
Make sure the yaml is fine, we unfortunately won't be able to know if this fixes things unless we merge to master.