cds-snc / covid-alert-server

Exposure Notification: Diagnosis Server implementation / Notification d’exposition : Mise en œuvre du serveur de diagnostic
Apache License 2.0
298 stars 31 forks source link

VA80 - KeyClaim (OneTimeCode) API requires different protection then OTC verification/key submission API's #99

Closed caitlintuba closed 4 years ago

caitlintuba commented 4 years ago

Service has two different user groups The keyclaim service implements functionality that would be used by health care providers, as well as the general public. These user groups are vastly different and by implementing the functionality in a shared service like this you are exposing the new-key-claim method to a wider audience of potentially malicious users.

REC-3 SEPARATE FUNCTIONALITY: The new-key-claim and claim-key methods should be split into separate services so that the audience for the new-key-claim method can be limited.

This came from the vulnerability analysis; originally Loudmouth Recommendation 3; was marked as low priority by security assessment team

whytoe commented 4 years ago

Is this a duplicate of #34

obrien-j commented 4 years ago

Before splitting this out into another microservice, investigate what options AWS WAF/ALB offers for path based+IP based routing/filtering:

Implement path/IP based WAF acl's

maxneuvians commented 4 years ago

We still need to set up the IP block sets for this

maxneuvians commented 4 years ago

Closed in #177