cds-snc / cra-claim-tax-benefits

A benefit signup prototype by the Canadian Digital Service
https://claim-tax-benefits.herokuapp.com/start
MIT License
4 stars 5 forks source link

[Very meta] Add code review guidelines #474

Closed pcraig3 closed 4 years ago

pcraig3 commented 4 years ago

@brdunfield, sorry to make you the first-ever person to be held to this Very High standard but someone's gotta be.


I went over a bunch of different sources for this. I tried to split the difference and come up with something that is useful for reviewers to read, both in terms of the tone of reviews and in the more technical terms of what we should look for.

Here are my sources:

sonarcloud[bot] commented 4 years ago

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information