search

cds-snc / cra-claim-tax-benefits

A benefit signup prototype by the Canadian Digital Service
https://claim-tax-benefits.herokuapp.com/start
MIT License
4 stars 5 forks source link

Skip adding index number to first radio input #529

Closed katedee closed 4 years ago

katedee commented 4 years ago

This PR changes it so that we skip adding the index number to the first radio input, in a list of radio buttons. This is so that our errorlist can then link to the first radio input, for better accessibility. Cypress tests updated as well

There shouldn't be conflict in the IDs, but if we feel we want to be extra careful, I can add a string at the end while generating the IDs? But looking as it is now, this shouldn't be happening so I'd like to avoid tacking on things

sonarcloud[bot] commented 4 years ago

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
12.0% 12.0% Duplication

katedee commented 4 years ago

Since our heroku deploys are having A Time™ linking to our PRs at the moment, here's the link to this deployment: https://cra-claim-ta-fix-radio-mhsfmkk.herokuapp.com/start