Task/english edits - Githubissues

cds-snc / cra-claim-tax-benefits

A benefit signup prototype by the Canadian Digital Service

https://claim-tax-benefits.herokuapp.com/start

MIT License

4 stars 5 forks source link

Task/english edits #541

Closed katedee closed 4 years ago

katedee commented 4 years ago

`/personal/name`

Resolves #533

`/offramp/address`

Resolves #534

`/offramp/maritalStatus`

Resolves #535

`/trillium/propertyTax/amount`

Resolves #536

`/confirmation`

Resolves #538

katedee commented 4 years ago

Hey @YedidaZalik based on how we're currently generating the table, it does pose a bit of code changing. Happy to take it on though :)

Unless, @pcraig3 can you think of an easy way to get that second or on it's own line at least? I tried a couple things to no avail!

katedee commented 4 years ago

Oooh I could run a check for that particular cell and then break up the text accordingly. What do y'all think?

YedidaZalik commented 4 years ago

It's okay if this can't be done. If the "or" cannot be bolded, then even if could be on a separate line without having to do a lot of work, that would be great. But if that is going to take up a lot of work, then I would say we can let this one go :)

katedee commented 4 years ago

@YedidaZalik Actually, I'm going to run a check on the cell and make those changes. Will be up either by lunch or shortly after :D

katedee commented 4 years ago

Aaaand updated! I don't know why I thought it would be so complicated 🤦‍♀ Blame it on the poor sleep

sonarcloud[bot] commented 4 years ago

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities (and 0 Security Hotspots to review)
0 Code Smells

No Coverage information
0.0% Duplication