search

cds-snc / cra-claim-tax-benefits

A benefit signup prototype by the Canadian Digital Service
https://claim-tax-benefits.herokuapp.com/start
MIT License
4 stars 5 forks source link

Remove the if65() function #542

Closed katedee closed 4 years ago

katedee commented 4 years ago

as now we log in user.json if they answer yes or no to being 65 and above This isn't necessary though, and this PR is very take-it-or-leave-it

The benefit to removing it is just having that little bit less of code to maintain I've marked it as "resolving" an issue, but in fact, the issue is resolved (full context in a comment on the issue)

image

sonarcloud[bot] commented 4 years ago

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

katedee commented 4 years ago

Closing because there's good reason not to go with this as outlined here: https://github.com/cds-snc/cra-claim-tax-benefits/issues/537#issuecomment-593487860