search

cds-snc / cra-claim-tax-benefits

A benefit signup prototype by the Canadian Digital Service
https://claim-tax-benefits.herokuapp.com/start
MIT License
4 stars 5 forks source link

Sort benefits table alphabetically in both en + fr #554

Closed katedee closed 4 years ago

katedee commented 4 years ago

Sort benefits table alphabetically wether in French or English.

To do this, I added an frHeader property tom compare for sorting. It means it’s a little extra text to maintain, but we probably won’t be changing benefit names too often.

Also added a space after some colons in the array of benefits objects, so that they’re all consistently formatted

English French
localhost_3005_confirmation (1) localhost_3005_confirmation_lang=fr (1)
sonarcloud[bot] commented 4 years ago

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information