Select component Figma updates

cds-snc / design-gc-conception

MIT License

4 stars 0 forks source link

Select component Figma updates #1002

Closed RavinaSamaroo closed 1 month ago

RavinaSamaroo commented 2 months ago

[x] Input is outside of frame
[x] FR select component with error and focus state has too much spacing

Done when

[x] Spacing is reviewed
[x] Figma comment is marked as resolved

Development impact

None

realdylanzheng commented 1 month ago

@RavinaSamaroo | cc: @adorayi

Error is a false-by-default boolean within the Select component and when it gets toggled to true it pushes the select field out of the visual frame, however upon inspecting the component's layers the select field is where it's supposed to be in the layer hierarchy (child of Select field, which is child of Select). It's just Figma behaviour, not a bug on our end.
The spacing has been fixed on the FR Select

Issue may be closed upon review, thanks.

RavinaSamaroo commented 1 month ago

@realdylanzheng this was actually an issue with the component being set to fixed height instead of hug contents. I am fixing it as part of the date input error state fixes.