Build dev : Topic template - Githubissues

cds-snc / design-gc-conception

MIT License

4 stars 0 forks source link

Build dev : Topic template #1119

Open ClementineHahn opened 2 months ago

ClementineHahn commented 2 months ago

Definition of Done

[x] Prior to doing work, clarify scope of ticket with the designers and adjust if necessary
[ ] Create HTML template
[ ] Template pull request exists and has been approved (not merged) in gcds-examples repository
- [ ] https://github.com/cds-snc/gcds-examples/tree/main/templates
[ ] tech lead has reviewed and all good

Acceptance Criteria

The topic template:

[x] has header
[x] has footer
[x] has MENU button
[x] has section title
[x] has topic title
[x] has a topic image (520 x 200)
[x] has Most requested section with 6 links
[x] has 9 doormat links (in 3 x 3 layout)
[x] has a feature image (360 x 203)
[x] has a feature link
[ ] has On social media section
[ ] Passes storybook a11y test without any violation
[ ] Dev peer reviews

Deliverables

[ ] Proposal guidance handed off to content for review
[ ] EN template content handed off to translation
[ ] Pull request opened, and approved but not yet merged

More info

We are referencing this page: https://servicecanada.github.io/wet-boew-demos/topic-template-demo/templates/topic/topic-en.html

ClementineHahn commented 2 months ago

@daine can you tell me if this breakdown would work for a build template card for dev ? thank you

daine commented 2 months ago

@ClementineHahn I've looked at the ticket over and it looks good, we can consider it groomed

ethanWallace commented 1 week ago

To finish development of the topic template. The grid spacing issue will need to be solved (https://github.com/cds-snc/design-gc-conception/issues/1106)