Dev: Details component + Link component Figma fixes - Githubissues

cds-snc / design-gc-conception

MIT License

4 stars 0 forks source link

Dev: Details component + Link component Figma fixes #1147

Open adorayi opened 2 months ago

adorayi commented 2 months ago

📇 User story

As a GCDS Components developer, I want to have the coded components for Link and Details aligned with their corresponding designs in figma

✅ Definition of Done / Outcomes

[x] Done when PR is opened and approved
[x] Done when PR is determined to be in the next release, in which it gets merged to main
[x] Do not release the package, releasing will be done on ticket #1172

📜 Acceptance criteria

[x] ~~Link: Mobile Link font token is set to 16px, 150% line height~~
[x] Mobile link size: textMobile
[x] Link: Spacing between text and icon on desktop is increased from 3px to 6px
[x] Link: Figma file
[x] ~~Details: Mobile Link font token is set to 16px, 150% line height~~
[x] Details mobile link size: textMobile
[x] Details: Spacing matches design
[x] Details: Figma file

ClementineHahn commented 1 month ago

Might need designer review after