cds-snc / design-gc-conception

MIT License
4 stars 0 forks source link

Documentation: Date input component #699

Closed adorayi closed 1 week ago

adorayi commented 8 months ago

Summary: Documentation of component guidance in EN for the date input component on the Design System website. Including use cases, how to use guidance, accessibility guidelines and more.

Acceptance Criteria:

SmartMouthWords commented 6 months ago

Did an initial review of the date input documentation , made edits and added questions.

Note: Doc is missing alt text and coding guidance

melaniebmn commented 5 months ago

@adorayi as discussed in dev sync: we can't write the coding guidance until we have developed the actual component which is work that was deprioritized a few sprints ago. Can we put this back into the backlog until we have developed the component itself? Dev ticket #698.

adorayi commented 1 month ago

@MatildePerrusclet this is ready for review. https://docs.google.com/document/d/17pc3Lg7QYPKtv1xt45GZ0ntX2Tl5oAYRpI-M7bU7hqs/edit

MatildePerrusclet commented 1 month ago

Done reviewing @adorayi Main concern is that there's already guidance regarding the date input order for the GC, it's YYYY-MM-DD for both languages.

Ref: "Choose a date input order to reduce error In English, generally use month-day-year and in French day-month-year."

Here are the links to the GC guidance: https://design.canada.ca/style-guide/#wp4-7 https://www.google.com/url?q=https://www.tbs-sct.canada.ca/pol/doc-eng.aspx?id%3D17284&sa=D&source=docs&ust=1724682711256927&usg=AOvVaw1zuNHNTQeWvIusL-GuHbpU

adorayi commented 1 month ago

Good point @MatildePerrusclet. Do we have rationale for why we went with this format? @realdylanzheng @RavinaSamaroo @ethanWallace

adorayi commented 3 weeks ago

Awaiting translation. @EliseKa please prioritize this.

EliseKa commented 2 weeks ago

Translation is almost complete (can be found in this doc), I'm just awaiting an answer for a clarifying question I asked in the English doc.

EliseKa commented 2 weeks ago

Translation complete and ready for bilingual review - doc already shared with @MatildePerrusclet

MatildePerrusclet commented 2 weeks ago

Translation has been reviewed and questions discussed with @EliseKa. The anatomy image has to be updated in FR @RavinaSamaroo and it's good to go for me :) FR document ENG document

RavinaSamaroo commented 2 weeks ago

Anatomy image and overview images were updated.