cds-snc / design-gc-conception

MIT License
4 stars 0 forks source link

Content issue from contact form #754

Open adorayi opened 8 months ago

adorayi commented 8 months ago

The page https://design-system.alpha.canada.ca/en/styles/typography/ says “Use headings for calls to action and to create emphasis.” These seem like situations where people specifically should not be using headers. Right? Also, in the “Italics” section on the same page, the law “Accessible Canada Act” isn’t italicised; is that deliberate? And is that name included in the text as an example of how to italicise a law (in which case it might want quotation marks) or as a reference for the previous statement (in which case it might want a more specific reference)?

Checkboxes are also called tickboxes in some quarters, so that might be a useful synonym to include.

Received from Kivi S.

SmartMouthWords commented 7 months ago

Fixed italics problem – PRs 311 and 312. Added tickboxes to content fix list and to Figma library also called section

Draft response

  1. The guidance provided for headings was intentional. We're recommending headings be used to:

    • highlight the main action in a direct call-to-action style format
    • emphasize the most important point in the section
    • summarize make it clear what content you'll find in section There's now additional guidance for headings on the heading component pages.
  2. Acts should be italicized. That was accidental and directly contradicts the guidance. Thanks for pointing this out!

  3. Adding "tickboxes" to the other names section. Thank you for this feedback.

SmartMouthWords commented 6 months ago

@adorayi or @brockhigg10 Do we need to follow up on the form?

adorayi commented 6 months ago

@SmartMouthWords all this is done and ready for review? I don't see tickboxes added to the other names on the website.

SmartMouthWords commented 6 months ago

@adorayi It's updated in the Figma library and on a list of content updates for component other names and definitions updates.

mcman12 commented 6 months ago

Still needs conversation on what stays and what doesn't on the items in the contact us form this work will be done in the community page review