Design - Remove Error Message background fill in Figma to align with Canada.ca style

cds-snc / design-gc-conception

MIT License

4 stars 0 forks source link

Design - Remove Error Message background fill in Figma to align with Canada.ca style #861

Closed adorayi closed 4 days ago

adorayi commented 4 months ago

Canada.ca's Contextual Alert

Acceptance criteria

[x] Error message component background is transparent
[x] Error message text is prefixed with an icon
[x] Error message text font weight is bold
[x] Error message text is red-700 (#A62A1E)
[x] Error message can be set/modified

Done when

[x] EN component is published
[x] FR component is published
[x] All EN components that use error are updated and published
[x] All FR components that use error are updated and published
[x] All EN posters with error state are updated and published
[x] All FR posters with error state are updated and published
[x] Figma file is linked in corresponding dev ticket
[x] Component history Figma file is updated with previous version and rationale (EN only)

Deliverables

[x] Figma | EN component
[x] Figma | FR component

adorayi commented 2 months ago

cc @melaniebmn to confirm before closing.

melaniebmn commented 1 month ago

@adorayi there is no matching dev ticket (as far as I know) for removing the error message background.

adorayi commented 1 month ago

Corresponding dev ticket linked as a dependency @melaniebmn

SmartMouthWords commented 1 month ago

Flagging there's a small discrepancy between the new error message anatomy and the anatomies of other components. When an icon is part of a component, it is labeled and described in each anatomy @adorayi @realdylanzheng Some examples:

melaniebmn commented 1 month ago

Note for future workflow alterations: alt text needed to be updated because the preview + anatomy images were changed.

realdylanzheng commented 1 month ago

@SmartMouthWords Updated error message anatomy (Figma) for your review. Thanks

realdylanzheng commented 1 month ago

@melaniebmn Which ticket should alt text, preview image, and anatomy image work be defined in: Content, Design, or Dev?

melaniebmn commented 1 month ago

@realdylanzheng I don't think that is my call to make but to me, it would make sense in all 3: The design team needs to update the preview + anatomy images, the content team needs to write the new alt text description, and the dev team needs to implement the new images + alt text.

@adorayi @ClementineHahn tagging you both as this seems workflow-related.