cds-snc / design-gc-conception

MIT License

4 stars 0 forks source link

Duplicate emitted events from angular components #926

Closed ethanWallace closed 4 months ago

ethanWallace commented 6 months ago

Summary

Based on feedback, the newest outputs update to the angular package is causing events to be emitted twice.

Acceptance criteria

[x] Investigate events in angular components
[x] Determine a plan to fix the events to only emit once.
[x] Fix the issue and test

ethanWallace commented 5 months ago

Duplicate events are emitted since the angular component uses the new @Outputs events and still has the old rxjs events from Stencil's implementation. To stop duplicate events, we will need to remove the rxjs event listeners.

adorayi commented 4 months ago

@ethanWallace do we need to open a new ticket for the work to remove rxjs event listeners?

ethanWallace commented 4 months ago

@abdul That work was completed in this PR https://github.com/cds-snc/gcds-components/pull/566