chore: remove unused StatsCan CNAMEs

[patheard]

Summary

Remove the records for statistics.alpha.canada.ca and statistique.alpha.canada.ca as these are no longer needed.

This is duplicating @justbert's PR #362 as a way to make sure the Terraform plan runs as expected.

Related

• Closes #362

[github-actions[bot]]

DNS

✅   Terraform Init: success ✅   Terraform Validate: success ✅   Terraform Format: success ✅   Terraform Plan: success ✅   Conftest: success

⚠️   Warning: resources will be destroyed by this change!

Plan: 0 to add, 0 to change, 4 to destroy

Show summary

| CHANGE | NAME | |--------|------------------------------------------------------------------------| | delete | `aws_route53_record._acme-challenge-statistics-alpha-canada-ca-CNAME` | | | `aws_route53_record._acme-challenge-statistique-alpha-canada-ca-CNAME` | | | `aws_route53_record.statistics-alpha-canada-ca-CNAME` | | | `aws_route53_record.statistique-alpha-canada-ca-CNAME` |

Show plan

```terraform Resource actions are indicated with the following symbols: - destroy Terraform will perform the following actions: # aws_route53_record._acme-challenge-statistics-alpha-canada-ca-CNAME will be destroyed # (because aws_route53_record._acme-challenge-statistics-alpha-canada-ca-CNAME is not in configuration) - resource "aws_route53_record" "_acme-challenge-statistics-alpha-canada-ca-CNAME" { - fqdn = "_acme-challenge.statistics.alpha.canada.ca" -> null - id = "Z33C47YI9EN8XL__acme-challenge.statistics.alpha.canada.ca_CNAME" -> null - multivalue_answer_routing_policy = false -> null - name = "_acme-challenge.statistics.alpha.canada.ca" -> null - records = [ - "statistics.alpha.canada.ca.challenges.cloud.statcan.ca", ] -> null - ttl = 300 -> null - type = "CNAME" -> null - zone_id = "Z33C47YI9EN8XL" -> null } # aws_route53_record._acme-challenge-statistique-alpha-canada-ca-CNAME will be destroyed # (because aws_route53_record._acme-challenge-statistique-alpha-canada-ca-CNAME is not in configuration) - resource "aws_route53_record" "_acme-challenge-statistique-alpha-canada-ca-CNAME" { - fqdn = "_acme-challenge.statistique.alpha.canada.ca" -> null - id = "Z33C47YI9EN8XL__acme-challenge.statistique.alpha.canada.ca_CNAME" -> null - multivalue_answer_routing_policy = false -> null - name = "_acme-challenge.statistique.alpha.canada.ca" -> null - records = [ - "statistique.alpha.canada.ca.challenges.cloud.statcan.ca", ] -> null - ttl = 300 -> null - type = "CNAME" -> null - zone_id = "Z33C47YI9EN8XL" -> null } # aws_route53_record.statistics-alpha-canada-ca-CNAME will be destroyed # (because aws_route53_record.statistics-alpha-canada-ca-CNAME is not in configuration) - resource "aws_route53_record" "statistics-alpha-canada-ca-CNAME" { - fqdn = "statistics.alpha.canada.ca" -> null - id = "Z33C47YI9EN8XL_statistics.alpha.canada.ca_CNAME" -> null - multivalue_answer_routing_policy = false -> null - name = "statistics.alpha.canada.ca" -> null - records = [ - "www-alpha.prod.cloud.statcan.ca", ] -> null - ttl = 300 -> null - type = "CNAME" -> null - zone_id = "Z33C47YI9EN8XL" -> null } # aws_route53_record.statistique-alpha-canada-ca-CNAME will be destroyed # (because aws_route53_record.statistique-alpha-canada-ca-CNAME is not in configuration) - resource "aws_route53_record" "statistique-alpha-canada-ca-CNAME" { - fqdn = "statistique.alpha.canada.ca" -> null - id = "Z33C47YI9EN8XL_statistique.alpha.canada.ca_CNAME" -> null - multivalue_answer_routing_policy = false -> null - name = "statistique.alpha.canada.ca" -> null - records = [ - "www-alpha.prod.cloud.statcan.ca", ] -> null - ttl = 300 -> null - type = "CNAME" -> null - zone_id = "Z33C47YI9EN8XL" -> null } Plan: 0 to add, 0 to change, 4 to destroy. ───────────────────────────────────────────────────────────────────────────── Saved the plan to: plan.tfplan To perform exactly these actions, run the following command to apply: terraform apply "plan.tfplan" ```

Show Conftest results

```sh WARN - plan.json - main - Missing Common Tags: ["aws_route53_zone.alpha-canada-ca-public"] WARN - plan.json - main - Missing Common Tags: ["aws_route53_zone.cds-snc-ca-public"] WARN - plan.json - main - Missing Common Tags: ["aws_route53_zone.notification-canada-ca-public"] WARN - plan.json - main - Missing Common Tags: ["aws_route53_zone.platform-canada-ca-public"] 23 tests, 19 passed, 4 warnings, 0 failures, 0 exceptions ```

[justbert]

LGTM! Thanks @patheard!