cds-snc / dns

DNS Configuration for domains managed by CDS
18 stars 15 forks source link

chore: Adding DKIM records for us-east-1 notification-canada-ca #384

Closed ben851 closed 3 months ago

ben851 commented 3 months ago

Summary | Résumé

The DKIM records for notification.canada.ca SES for us-east-1 were not here, and as such DKIM validation is failing in production.

Test instructions | Instructions pour tester la modification

TF Apply works Trigger DKIM validation on production notify SES

github-actions[bot] commented 3 months ago

DNS

✅   Terraform Init: success ✅   Terraform Validate: success ✅   Terraform Format: success ✅   Terraform Plan: success ✅   Conftest: success

Plan: 3 to add, 0 to change, 0 to destroy
Show summary | CHANGE | NAME | |--------|-------------------------------------------------------------------| | add | `aws_route53_record.dkim1-notification-canada-ca-us-east-1-CNAME` | | | `aws_route53_record.dkim2-notification-canada-ca-us-east-1-CNAME` | | | `aws_route53_record.dkim3-notification-canada-ca-us-east-1-CNAME` |
Show plan ```terraform Resource actions are indicated with the following symbols: + create Terraform will perform the following actions: # aws_route53_record.dkim1-notification-canada-ca-us-east-1-CNAME will be created + resource "aws_route53_record" "dkim1-notification-canada-ca-us-east-1-CNAME" { + allow_overwrite = (known after apply) + fqdn = (known after apply) + id = (known after apply) + name = "iymb7ahbsrpfy7ktku4tpibh2n3a2hdk._domainkey.notification.canada.ca" + records = [ + "iymb7ahbsrpfy7ktku4tpibh2n3a2hdk.dkim.amazonses.com", ] + ttl = 300 + type = "CNAME" + zone_id = "Z1XG153PQF3VV5" } # aws_route53_record.dkim2-notification-canada-ca-us-east-1-CNAME will be created + resource "aws_route53_record" "dkim2-notification-canada-ca-us-east-1-CNAME" { + allow_overwrite = (known after apply) + fqdn = (known after apply) + id = (known after apply) + name = "z7ujljo4n4hbl4slxawnomvstjhlbgx2._domainkey.notification.canada.ca" + records = [ + "z7ujljo4n4hbl4slxawnomvstjhlbgx2.dkim.amazonses.com", ] + ttl = 300 + type = "CNAME" + zone_id = "Z1XG153PQF3VV5" } # aws_route53_record.dkim3-notification-canada-ca-us-east-1-CNAME will be created + resource "aws_route53_record" "dkim3-notification-canada-ca-us-east-1-CNAME" { + allow_overwrite = (known after apply) + fqdn = (known after apply) + id = (known after apply) + name = "pjmdrlcl2vsjodh4ruc4v2oogw5cs2cl._domainkey.notification.canada.ca" + records = [ + "pjmdrlcl2vsjodh4ruc4v2oogw5cs2cl.dkim.amazonses.com", ] + ttl = 300 + type = "CNAME" + zone_id = "Z1XG153PQF3VV5" } Plan: 3 to add, 0 to change, 0 to destroy. ───────────────────────────────────────────────────────────────────────────── Saved the plan to: plan.tfplan To perform exactly these actions, run the following command to apply: terraform apply "plan.tfplan" ```
Show Conftest results ```sh WARN - plan.json - main - Missing Common Tags: ["aws_route53_zone.alpha-canada-ca-public"] WARN - plan.json - main - Missing Common Tags: ["aws_route53_zone.cds-snc-ca-public"] WARN - plan.json - main - Missing Common Tags: ["aws_route53_zone.notification-canada-ca-public"] WARN - plan.json - main - Missing Common Tags: ["aws_route53_zone.platform-canada-ca-public"] 23 tests, 19 passed, 4 warnings, 0 failures, 0 exceptions ```