Design: Add visited state to Link

cds-snc / gcds-components

GC Design System Components is a monorepo managing the web components of the GC Design System. | « GC Design System Components » (Composants de Système de design GC) est un référentiel unique qui gère les composants Web de Système de design GC.

https://design-system.alpha.canada.ca/

MIT License

35 stars 11 forks source link

Design: Add visited state to Link #571

Closed adorayi closed 3 weeks ago

adorayi commented 3 months ago

Summary: Update design of the link component to include a visited state, to align with Canada.ca. Design on component branch and push to main Figma file when approved.

Acceptance Criteria

[x] Link visited state has colour: #7532B8
[x] Link has value: Visited within property: State

Definition of done

[x] EN component is ready for merge
[x] FR component is ready for merge
[x] Update #572 (dev ticket) with link to design
[x] Review and update requirements doc with developer (if applicable)

Deliverables

[x] EN component
[x] FR component

Dev impact

Yes - Add visited link state to code #572

adorayi commented 3 months ago

Would the visited state apply to all link component instances or not.

realdylanzheng commented 2 months ago

@adorayi 'push to main Figma when approved' - who's to approve? How do we take into consider what has transpired with the incidents?

adorayi commented 2 months ago

@realdylanzheng as long as other designers have reviewed and it's been shown to devs for feedback as well it can be pushed.

melaniebmn commented 2 months ago

Note: after talking to @realdylanzheng we decided to change the colour from #7834BC to #7532B8 to keep a minimum 7:1 colour contrast ratio that we ensure for all other 700 and above colour tokens.

melaniebmn commented 2 months ago

@realdylanzheng can we add the new purple colour to the "Styles" page in Figma as well to make sure we keep track of all of our colours there as well?