search

cds-snc / ircc-rescheduler

🙅🗓
https://vancouver.rescheduler-dev.cds-snc.ca/
MIT License
24 stars 7 forks source link

NoJS - explanation page flow #476

Closed timarney closed 5 years ago

timarney commented 5 years ago

@pcraig3 thinking this needs the updated validate code from the other PR.

emanelfy commented 5 years ago

Background colour: #eeeeee

Placement: At the top of the page underneath "Citizenship appointments in October are scheduled on Tuesdays and Wednesdays."

Link (blue and underlined): I cannot attend any of these appointments.

Size: Should match the checkbox text.

Focus: Even though this appears at the top of the page, the focus of this element should be the last thing before the submit button.

-- cc @timarney @pcraig3

pcraig3 commented 5 years ago

Okay, updated this to always reset the explanationPage value when calendar values are saved successfully.

To verify correct behaviour, you can add 

        <pre>{JSON.stringify(this.props.context.store, null, 2)}</pre>

to line 100 of the ReviewPage.js file.

timarney commented 5 years ago

Will approve this once it's passing (translations are in).

timarney commented 5 years ago

Will approve this once it's passing (translations are in).

Looks like you have to approve it. Original commit are mine.