search

cds-snc / ircc-rescheduler

🙅🗓
https://vancouver.rescheduler-dev.cds-snc.ca/
MIT License
24 stars 7 forks source link

Nearly final round of updates #518

Closed pcraig3 closed 5 years ago

pcraig3 commented 5 years ago

Did another round of updates and went down a few rabbit holes. 🐰🐰🐰

  1. Breaking change to emotion meant that our federal banner disappeared without JS for some reason. Luckily, @nmakuch fixed it by recreating the Federal Banner in our app.
  2. Since we were only using the ErrorBoundary from GCUI after Nick's change, I pulled it into our app as well and then removed GCUI as a dependency.
  3. Some puppeteer tests started to fail randomly with some hard-to-track-down error, so I updated the "wait for this action to finish" time and swapped one set of tests over to query strings and that seems to have fixed it.

As of this point our packages are up to date, and we shaved a minuscule amount of code off our bundle size.

pcraig3 commented 5 years ago

gonna merge