cds-snc / ircc-rescheduler

🙅🗓
https://vancouver.rescheduler-dev.cds-snc.ca/
MIT License
24 stars 7 forks source link

Don't show "Phone -" on 500 page if no location #520

Closed pcraig3 closed 5 years ago

pcraig3 commented 5 years ago

Our root domain has no location set, so we don't have contact information to show users.

Right now, it will say Phone — but then not have a phone number.

Instead, we should omit the Contact output entirely if there is no contact info.

Screenshots

before after
when there is a location ('vancouver' in the URL string), there is a phone number. When there is no location, there is no phone number to call.
screen shot 2018-12-20 at 2 39 35 pm screen shot 2018-12-20 at 2 39 42 pm

This PR removes the Phone — line in the second screenshot.

pcraig3 commented 5 years ago

I know! This is a great case for them! 😢

pcraig3 commented 5 years ago

Anyway, we can test on staging 😉

pcraig3 commented 5 years ago

Works now!

https://rescheduler-dev.cds-snc.ca/500

screen shot 2018-12-20 at 3 16 29 pm