search

cds-snc / ircc-rescheduler

🙅🗓
https://vancouver.rescheduler-dev.cds-snc.ca/
MIT License
24 stars 7 forks source link

Less tests 😭 #536

Closed pcraig3 closed 5 years ago

pcraig3 commented 5 years ago

This pull request sets us up for future deployments.

We need to be able to change the dates that show up on the calendar, and we also want to add a warning banner to the site, but before we do that, we need the tests to pass on CI so that we can deploy the container.

Skip the tests that send an email.

Since we're no longer adding the credentials to the container, the tests won't be able to send the email, which means they will fail.

This is not an elegant solution but it is an expedient one.

Removed dependency on aws credentials

This is the code from #532.

From @dsamojlenko

Updated infrastructure removes the need for the app to have access to AWS credentials in the environment. Once it's deployed, this change can be merged.

pcraig3 commented 5 years ago

Gonna just merge this as the tests have run. LGTM seems to be confused.