cds-snc / node-starter-app

Quick start application setup.... because you have to start somewhere.
MIT License
5 stars 3 forks source link

Add hint text to radios and checkboxes #110

Closed keithiopia closed 4 years ago

keithiopia commented 4 years ago

Add ability to put hint text underneath multiple choice questions (radios and checkboxes). Steve A did 98% of this work.

Co-Authored-By: @sastels

timarney commented 4 years ago

Nice - looks good if someone has some time to fix up the conflicts

timarney commented 4 years ago

Looks like the conflicts are mostly caused by the new required "true" attribute.

Which added see https://github.com/cds-snc/node-starter-app/issues/98

 {% if attributes.required %}
                <span aria-hidden="true" class="required">*</span>
            {% endif %}
            {{ __(question) }}
            {% if attributes.required %}
                <span class="required">{{ __("required")}}</span>
            {% endif %}
Screen Shot 2019-10-23 at 12 15 13 PM
sastels commented 4 years ago

I can take a look at the conflicts.