search

cds-snc / node-starter-app

Quick start application setup.... because you have to start somewhere.
MIT License
5 stars 3 forks source link

The repeater! #132

Closed jneen closed 4 years ago

jneen commented 4 years ago

This pull request includes the repeater, as well as the refactoring necessary to make it work.

Why do we need to refactor like this? The TLDR is: we need to be able to access the data from helpers, which means it needs to be registered on res.locals instead of passed into res.render(...).

jneen commented 4 years ago

One last question @timarney: should this be merged to master given that it is a major breaking change?

jneen commented 4 years ago

I also agree that this PR grew a bit too large. I likely would have added the repeater functionality in a separate branch, but I had been under the impression that it was important to get this through before my family leave based on discussions with @rossferg. We had also already finished the coding in the 2620 branch, and this was a simple port.

Many of the changes here were me cleaning up as I went, attempting to make the codebase nicer than how I found it - especially as some of those design decisions that had been made in haste blocked the way forward.

jneen commented 4 years ago

Okay! Without further input, I think it's best to merge to master so we can move forward from here. Thanks!