Cleanup macros

[CalvinRodo]

Did some light cleanup work in the macros to remove some copy and pasted sections and pull them into their own macros should improve maintainability.

• Created a hintText macro in hint-text.njk
  • renders hint text on control if attributes.hint is set
• Created a labelText macro in label-text.njk
  • renders required if attributes.required is true
• Moved if statement into validationMessage macro and renamed file to make it consistent with other controls.

I also moved macros that are only included in other macros into sub-macros folder (I can't think of a better name right now).

These could also be mashed up into a single file and import from there instead of having 3 imports in each file. However I've got some old baggage from my C# days about having only one thing per file.

[timarney]

First off I like this idea as it cleans things up in general and makes it easier to modify from a single spot.

@jneen do you see any issues getting this merged into the work your doing in https://github.com/cds-snc/node-starter-app/pull/132? I'm not spotting anything major at given a quick look.

[CalvinRodo]

Changelog has been updated

[timarney]

@CalvinRodo feel free to merge.

[jneen]

Oy, okay, just seeing this now. It's going to be a bit of work to integrate this.

[timarney]

Holding for @jneen to review.

[jneen]

I think that might be best - this seems easier to rebase against my changes. The only major thing that would have to change is the validationMessage macro, which currently seems to ignore its msg parameter. It should take just the relname parameter and use getError.