cds-snc / node-starter-app

Quick start application setup.... because you have to start somewhere.
MIT License
5 stars 3 forks source link

Add explicit max-height to svg container (for IE11) #145

Closed pcraig3 closed 4 years ago

pcraig3 commented 4 years ago

On IE on Windows 7 and under, the height of the SVG in the header is far too large, even though it visually is the right size. (that is, there is a lot of whitespace underneath the img element.)

Checked how Canada.ca solves this problem and they set a max-height at 40px, which seems to work and isn't too complicated.

Looked up some Stackoverflow questions but they mostly had complicated fixes so gonna go with this instead.

Screenshot

before after
Screen Shot 2019-12-10 at 9 42 13 AM Screen Shot 2019-12-10 at 10 13 28 AM
jneen commented 4 years ago

LGTM, thanks Paul!