cds-snc / node-starter-app

Quick start application setup.... because you have to start somewhere.
MIT License
5 stars 3 forks source link

Cloudbuild.yaml references notification-demo #5

Closed dj2 closed 5 years ago

dj2 commented 5 years ago

The cloudbuild.yaml file should probably be copied to a cloudbuild.yaml.example and the notification-demo things marked as needing to be updated.

https://github.com/cds-snc/node-starter-app/blob/57a79ad8591013f51cd136fba8010d748305bdea/cloudbuild.yaml#L7

timarney commented 5 years ago

Agreed.

timarney commented 5 years ago

@maxneuvians updated the file to use node-starter-app + project ID so when using this file no updates need to be made by the user.