search

cds-snc / node-starter-app

Quick start application setup.... because you have to start somewhere.
MIT License
5 stars 3 forks source link

Simplify text input attributes/interface #57

Closed dsamojlenko closed 5 years ago

dsamojlenko commented 5 years ago

related to #48

timarney commented 5 years ago

@dsamojlenko let me know when you want me to take another look at this.

dsamojlenko commented 5 years ago

@timarney yeah, I think this is good ... removed the value attribute, using data[name] ... cleaned up a few things.

This doesn't address what we'd talked about with the radio/checkboxes ... just text inputs.

timarney commented 5 years ago

This doesn't address what we'd talked about with the radio/checkboxes ... just text inputs.

This should help with that issue.

https://github.com/cds-snc/node-starter-app/pull/69

timarney commented 5 years ago

Note: will need to add this textArea as well. Not sure if you want to add that to this PR.

timarney commented 5 years ago

Also let's start tracking these updates here in a changelog file

https://github.com/cds-snc/node-starter-app/pull/70

timarney commented 5 years ago

If you pull down the latest - you can make a note of the updates in the changelog file.

Outside of that + bumping the version should be good on this 👍