Pass a real route object into the controller

cds-snc / node-starter-app

Quick start application setup.... because you have to start somewhere.

MIT License

5 stars 3 forks source link

Pass a real route object into the controller #82

Closed jneen closed 4 years ago

jneen commented 4 years ago

This allows us to package up the routing information into a single object that is passed into the controller. I've also realized the RoutingTable object, which greatly simplifies the navigation through the routes list.

lgtm-com[bot] commented 4 years ago

This pull request introduces 1 alert when merging 220c6c52b8884667a1f376f2bc10bfb63014f4b1 into b32823f7e3ea4a232f84142d05cf497e6fdcc0d1 - view on LGTM.com

new alerts:

1 for Unused variable, import, function or class

lgtm-com[bot] commented 4 years ago

This pull request introduces 1 alert when merging 0656b8eada2fb9cc7b06d1244e040c110ccdb20d into b32823f7e3ea4a232f84142d05cf497e6fdcc0d1 - view on LGTM.com

new alerts:

1 for Unused variable, import, function or class

timarney commented 4 years ago

This is great. Few comments and the linting errors to cleanup.

Outside of that please bump the version in package.json + track the changes in the changelog file

Added, Updated, Removed.

@maxneuvians , @dsamojlenko feedback would be appreciated.

maxneuvians commented 4 years ago

LGTM