Create a new DRYRUN_TEST_NUMBER that uses dryrun=True and switch the INTERNAL_TEST_NUMBER to just be internal (ie no boto call) as it used to be. This will allow us to load test the internals of Notify without having throttling errors (when we use the dryrun option).
Test instructions | Instructions pour tester la modification
Send to INTERNAL_TEST_NUMBER = "+16135550123"
should see in the logs something similar to:
[2024-11-04 20:24:18,291: INFO/ForkPoolWorker-5] notification d14da0e2-8c73-4cf3-a7a3-aa11141a6c86 is sending to INTERNAL_TEST_NUMBER, no boto call to AWS.
should not see a record in the AWS Pinpoint logs PinpointDirectPublishToPhoneNumber
Send to DRYRUN_TEST_NUMBER = "+16135550124"
should see in the logs something similar to:
[2024-11-04 20:22:13,332: INFO/ForkPoolWorker-5] SMS with message id 9792b3e8-2137-4a0d-8420-07bc6c325582 is sending to DRYRUN_TEST_NUMBER. Boto call made to AWS, but not send on.
should not see a record in the AWS Pinpoint logs PinpointDirectPublishToPhoneNumber
Release Instructions | Instructions pour le déploiement
None.
Reviewer checklist | Liste de vérification du réviseur
[ ] This PR does not break existing functionality.
[ ] This PR does not violate GCNotify's privacy policies.
[ ] This PR does not raise new security concerns. Refer to our GC Notify Risk Register document on our Google drive.
[ ] This PR does not significantly alter performance.
[ ] Additional required documentation resulting of these changes is covered (such as the README, setup instructions, a related ADR or the technical documentation).
⚠ If boxes cannot be checked off before merging the PR, they should be moved to the "Release Instructions" section with appropriate steps required to verify before release. For example, changes to celery code may require tests on staging to verify that performance has not been affected.
Summary | Résumé
Create a new DRYRUN_TEST_NUMBER that uses
dryrun=True
and switch the INTERNAL_TEST_NUMBER to just be internal (ie no boto call) as it used to be. This will allow us to load test the internals of Notify without having throttling errors (when we use the dryrun option).Related Issues | Cartes liées
Test instructions | Instructions pour tester la modification
PinpointDirectPublishToPhoneNumber
PinpointDirectPublishToPhoneNumber
Release Instructions | Instructions pour le déploiement
None.
Reviewer checklist | Liste de vérification du réviseur