search

cds-snc / notification-planning-core

Project planning for GC Notify Core Team
0 stars 0 forks source link

Bad org invite tokens cause 500 error #131

Closed sastels closed 1 year ago

sastels commented 1 year ago

Describe the bug

using a bad token for an organisation invitation causes a 500 error in admin.

Bug Severity

See examples in the documentation

SEV-4 Low

To Reproduce

Steps to reproduce the behavior:

  1. visit https://staging.notification.cdssandbox.xyz/organisation-invitation/%3Ctoken%3E
  2. observe that you see a 500 error

Expected behavior

Impact

clutters ops channel

QA steps

  1. visit https://staging.notification.cdssandbox.xyz/organisation-invitation/%3Ctoken%3E
  2. observe that you do not see a 500 error
sastels commented 1 year ago

PR to fix https://github.com/cds-snc/notification-admin/pull/1575

andrewleith commented 1 year ago
andrewleith commented 1 year ago

Looks good on staging and prod ✅