Terraform Scratch Account Fixes

[ben851]

Description

As a developer/operator of Notify, I want to be able to deploy the AWS environment to my scratch account so that I can debug/test notify in a safe cloud environment. The environment now builds from scratch but there are some bugs/fixes in the code that need to be done in order to streamline the process.

WHY are we building?

This will allow devs to become more familiar with the infrastructure, and provide new methods to test the notify code.

WHAT are we building?

On the first group session to create scratch accounts the following issues were discovered:

• [x] Remove the Sqlalchemy connection strings from the TFVars file and get the programmatically
• [x] Set the base domain once in the tfvars and remove all other url definitions
• [ ] Change s3 bucket names programmatically (validate the var.env can be changed)
• [ ] Truncate S3 length
• [ ] Verify references to scan files s3 bucket is done via object and not string
• [ ] Remove values from env_vars.hcl

[CalvinRodo]

A nice to have from an organizational perspective is to scale down the resources provisioned for scratch accounts.

[ben851]

Yep for sure, it will be addressed before we all start spinning these up willy nilly.

[ben851]

• Ben to merge approved PR on base domains to staging today.

[ben851]

• Deployed to staging, verified smoke test works
• Created secrets in production for GH Actions base URL

[ben851]

• Need to release to production