cds-snc / notification-planning-core

Project planning for GC Notify Core Team
0 stars 0 forks source link

Delete bulk-send and inspec-scanner IAM users #170

Open sastels opened 11 months ago

sastels commented 11 months ago

Description

As a Notify developer, I need the repo to have as little unused code as possible.

WHY are we building?

We no longer use the bulk-send and inspec-scanner IAM users (the credentials were disabled months ago without complaints) so we can delete the users.

WHAT are we building?

Delete the bulk-send and inspec-scanner IAM users

VALUE created by our solution

cleaner code code runs better

Acceptance Criteria

Given some context, when (X) action occurs, then (Y) outcome is achieved.

QA Steps

sastels commented 11 months ago

https://github.com/cds-snc/notification-terraform/pull/851

ben851 commented 11 months ago

Ben to review PR

ben851 commented 11 months ago

Need to release the force destroy PR to prod before merging to staging.

ben851 commented 11 months ago

Merge to staging initially failed due to click-ops account credentials. Steve manually removed and merge succeeded. Steve to check prod for credentials.

sastels commented 11 months ago

inspec-scanner creds manually deleted in prod

jimleroyer commented 11 months ago

Requires a Terraform release. Plan to do it today. Credentials were deleted in Prod last week.

sastels commented 11 months ago

released in prod

jimleroyer commented 11 months ago

I will QA today!

jimleroyer commented 10 months ago

QA'ed: