cds-snc / notification-planning-core

Project planning for GC Notify Core Team
0 stars 0 forks source link

Move email delivery into their own dedicated queues #206

Open sastels opened 11 months ago

sastels commented 11 months ago

Description

As a Notify developer, I need email delivery tasks to be in their own queues so that I can treat them differently than other tasks (ex database, callbacks).

WHY are we building?

Moving email delivery to their own queues will allow us to scale up email delivery without scaling up other tasks such as database operations or callback processing. This will also allow better monitoring and alarming for email delivery issues.

WHAT are we building?

Move email delivery tasks to their own dedicated celery queues. Note that this task does not include moving the email delivery tasks to their own dedicated pool of celery workers.

VALUE created by our solution

We will be able to scale up email delivery without scaling up other parts of the system.

Acceptance Criteria

QA Steps

sastels commented 11 months ago

PR to use the new queues in celery: https://github.com/cds-snc/notification-api/pull/1997

sastels commented 11 months ago

PR to add alarms for the new queues https://github.com/cds-snc/notification-terraform/pull/962

sastels commented 11 months ago

PR to add the queues to the email dashboard https://github.com/cds-snc/notification-terraform/pull/963

sastels commented 11 months ago

These PRs can wait to be merged / released after I'm back (Oct 23)

ben851 commented 11 months ago

Jimmy approved and improved the PRs!

To be merged today after am release

sastels commented 11 months ago

in production

jimleroyer commented 11 months ago

Looks like it's working 👍

Private Zenhub Image