cds-snc / notification-planning-core

Project planning for GC Notify Core Team

0 stars 0 forks source link

clean up unused email / sms delivery queues #209

Open sastels opened 11 months ago

sastels commented 11 months ago

Description

As a developer, I need to clean up unused code.

WHY are we building?

Clean up unused code related to the now unused send-email-tasks and send-sms-tasks queues.

WHAT are we building?

Delete alarms, variables, and dashboard widgets related to these queues. Also delete code from the api repo related to these queues.

VALUE created by our solution

Less unused code / alarms / dashboards

Acceptance Criteria

Given some context, when (X) action occurs, then (Y) outcome is achieved.

[x] Verify that send-sms-tasks and send-email-tasks are no longer being used
[x] Alarms / dashboard widgets / variables are deleted from the terraform repo
[x] Related code in config.py (api repo) is deleted

QA Steps

[x] code deleted
[x] no alarms go off
[x] Test the 3 priorities in staging

sastels commented 6 months ago

PR to remove queues from api / celery https://github.com/cds-snc/notification-api/pull/2148

sastels commented 6 months ago

send-email-tasks, zero usage in production last month:

send-sms-tasks, zero usage in production last month:

sastels commented 6 months ago

PR to remove queues from api / celery cds-snc/notification-api#2148

P0NDER0SA commented 6 months ago

There's a PR that needs eyes on it to review and get merged. Steve will send us a notice

sastels commented 6 months ago

Corresponding terraform PR! https://github.com/cds-snc/notification-terraform/pull/1230

sastels commented 6 months ago

Also have to delete alarms from the google sheet

sastels commented 6 months ago

merged into staging yesterday. Tested with all priorities and on api and admin

sastels commented 6 months ago

in production

ben851 commented 6 months ago

Sent emails in both staging and prod in all 3 queues