cds-snc / notification-planning-core

Project planning for GC Notify Core Team
0 stars 0 forks source link

Large SMS csv fails and causes 500 error #210

Closed sastels closed 8 months ago

sastels commented 8 months ago

Describe the bug

I have a file of 40K SMS using our internal test number (ie doesn't actually send to AWS).

phone number
+16135550123
+16135550123
...

Uploading the CSV works, but when I click "Send now" I get a server error

Sorry, we’re experiencing technical difficulties
Try again later.

the messages do not send nor are they in the dashboard.

Bug Severity

See examples in the documentation

SEV-3 Minor I don't think many users upload large SMS files right now. At least, we're not seeing many 500 errors. Note that any that do may have this problem.

To Reproduce

Steps to reproduce the behavior:

  1. Set your email and SMS limits to 50K or so.

  2. create a file of 40K SMS of the form

    phone number
    +16135550123
    +16135550123
    ...
  3. Try to send now

  4. See error

Expected behavior

No error, SMS send

Impact

Users cannot send large SMS csvs

Notes:

Additional context

Get an error in the api lambda

Job not found in database for service_id 1c31507f-a7ec-4102-9cbe-c648388c1e8a job_id ec4897bb-10c0-420d-b6c6-d7bc376207cf

This was in staging )