ADR for the phone pool system

[jimleroyer]

Description

As a technical steak holder 🥩 , I need to understand and review our options on how we can isolate SMS codes, so that we have consensus on the needs, requirements and solutions.

WHY are we building?

Provide technical analysis and review of how we isolate codes. This is needed for us to dedicate certain code to certain usage by users. For example the short needs to be exclusively reserved for 2FA usage, or the dedicated long codes need to be reserved for certain services.

WHAT are we building?

We are building an abstraction for pool of codes that can be associated per service or per template or by default (as a fallback).

VALUE created by our solution

For the ADR,

• this provides a track record for the organization of our technical decision,
• this provides a platform for review and consensus.

Acceptance Criteria

• [ ] Review by notify core team.
• [ ] Review by notify product manager and app core dev lead.
• [ ] Review or heads to the platform core team.
• [ ] Review or heads to the security team.

QA Steps

• [ ] Signed off by steak holders 🥩✋

[jimleroyer]

Drafted context and summary, will add discussed options and tasks next: https://github.com/cds-snc/notification-adr/pull/60

[ben851]

Jimmy continued to develop this yesterday and will share it.

[ben851]

Jimmy used a cool mermaid graph!

[jimleroyer]

@sastels reviewed and left a comment. There is a confusing part that I will fix today.

[jimleroyer]

I will make changes to fix the bad copy/paste text I introduced and that led to confusion.

[ben851]

Jimmy is working on it!

[jimleroyer]

Just pushed the ADR fix to the PR.

[sastels]

Steve will go take a look!

[jimleroyer]

We just merged into the main branch after a back and forth between Steve and I. 🙇‍♂️🎉