search

cds-snc / notification-planning-core

Project planning for GC Notify Core Team
0 stars 0 forks source link

Dedicated long codes not always used #348

Open sastels opened 5 months ago

sastels commented 5 months ago

Describe the bug

Dedicated long codes not always used.

Bug Severity

See examples in the documentation

SEV-3 Minor - notifications still sent (using long code pool) but with the wrong numbers

To Reproduce

Steps to reproduce the behavior:

  1. Set up a service with a dedicated number
  2. upload a csv sending an sms or two to yourself
  3. see that the number that is used is not the dedicated number

Expected behavior

dedicated number always used.

Impact

Services with dedicated numbers might not have these numbers used.

Additional context

https://cds-snc.freshdesk.com/a/tickets/17255

sastels commented 5 months ago

WIP fix https://github.com/cds-snc/notification-api/pull/2163

P0NDER0SA commented 4 months ago

approved and ready to merge!

sastels commented 4 months ago

merged Thursday, will release today

sastels commented 4 months ago

released, asked the user that reported the problem to test again.

sastels commented 4 months ago

user tested and working now

ben851 commented 4 months ago

Working - QA'ed by the customer!