Turn on new Pinpoint code in staging

[sastels]

Description

As a Notify user, I need my SMS to be sent from the appropriate numbers As a Notify developer i'd would like my pinpoint experience to be POSSIBLE

WHY are we building?

We have brought the pinpoint code back into the code base and it seems to be working. We will now enable it in staging.

WHAT are we building?

Turn on Pinpoint code in staging. This card is scoped to staging environment

VALUE created by our solution

Pinpoint is inherently valuable to Notify Will be confident that we can enable in production

Acceptance Criteria

• [x] turn on sc pool for a few templates. SNS used for everything else
• [ ] add default pool variable to k8s with empty value. Verify that we still use SC pool for sc templates, SNS for everything else
• [ ] set default pool variable. Should use sc for sc templates, default pool for most other sms, SNS for sending to US or services with designated numbers
• [ ] add alarms and make dashboard changes

QA Steps

• [ ] Send an sms using a template in the shortcode list. It should be sent from the Pinpoint shortcode pool.
• [ ] Send an sms using a template not in the list. It should be sent from the Pinpoint default pool.
• [ ] Send an sms to our internal test number 16135550123. This should not be actually sent but marked as delivered.
• [ ] Send an sms using a service with a dedicated number. If should be sent through SNS (and from the dedicated number)
• [ ] Send an sms to a US number (ex: 7065550123, a fake number in Georgia). If should be sent through SNS
• [ ] Send an email to verify that they still work.
• [ ] Unsubscribe via STOP adds you to the opt-out list.
• [ ] We can remove you from the opt-out list.
• [ ] Sends appear in dashboard

[sastels]

Add new AWS_PINPOINT_DEFAULT_POOL_ID variable to k8s: https://github.com/cds-snc/notification-manifests/pull/2627

rename the "longcode-pool" to "default-pool" https://github.com/cds-snc/notification-terraform/pull/1339

[sastels]

PRs merged, looks like stuff is working :tada:

[sastels]

fake test number was leading to a broken callback :/ reverted out turning on in staging and will fix, then turn back on...

[sastels]

Fix for the fake callbacks with Pinpoint: https://github.com/cds-snc/notification-api/pull/2178

After that merges we can turn Pinpoint back on (in staging) by reverting our reverted PR: https://github.com/cds-snc/notification-manifests/pull/2636

[P0NDER0SA]

Jimmy/Team can review these

[jimleroyer]

All latest PRs are reviewed. 🎊

[jimleroyer]

All latest PRs are reviewed. 🎊

[sastels]

:heart:

[P0NDER0SA]

Minor update then we can QA

[sastels]

Ready for another look https://github.com/cds-snc/notification-api/pull/2178

[ben851]

Steve will merge in today!

[sastels]

merged in, tested in staging by sending to the test number 16135550123 using a pinpoint sc template.

[sastels]

Next steps: https://github.com/cds-snc/notification-manifests/pull/2636 (already approved)

[sastels]

tweak for how empty pool ids are treated https://github.com/cds-snc/notification-api/pull/2191

Merged and tested in staging. Will release and verify in prod tomorrow. UPDATE: DONE

Next Steps:

• bring AWS_PINPOINT_DEFAULT_POOL_ID into staging with an empty value
• then release to prod with an empty value
• then set the value in staging
• then set the value in prod

[sastels]

PR to add empty AWS_PINPOINT_DEFAULT_POOL_ID https://github.com/cds-snc/notification-manifests/pull/2668

update: conflict in encrypted vars needs to be resolved before review and merge :/

[sastels]

Made some new cards to break down the work (and include both staging and prod sides of the work):

• Create Pinpoint SMS alarms and dashboard
• Enable the Pinpoint default pool

[sastels]

Closing, will do work in those new cards