sastels commented 3 weeks ago

Description

As a Notify user, I need my SMS to be sent from the appropriate numbers

WHY are we building?

We have brought the pinpoint code back into the code base and it seems to be working. We will now enable it in production.

WHAT are we building?

Turn on Pinpoint code in production: both shortcode pool and default pool

VALUE created by our solution

Will be able to restrict shortcode usage.

Acceptance Criteria

[ ] Add default pool variable to k8s with empty value. Verify that we still use SC pool for sc templates, SNS for everything else.
[ ] After alarms and dashboards modified on staging, release and verify on production.
[ ] Set default pool variable. Should use sc for sc templates, default pool for most other sms, SNS for sending to US or services with designated numbers.

QA Steps

[ ] Send an sms using a template in the shortcode list. It should be sent from the Pinpoint shortcode pool.
[ ] Send an sms using a template not in the list. It should be sent from the Pinpoint default pool.
[ ] Send an sms using a service with a dedicated number. If should be sent through SNS (and from the dedicated number)
[ ] Send an sms to a US number (ex: 7065550123, a fake number in Georgia). If should be sent through SNS
[ ] Send an email to verify that they still work.
[ ] Unsubscribe via STOP to the shortcode and verify that you're on the opt out list.
[ ] Remove your self from the opt out list.

sastels commented 3 weeks ago

Side note: looks like our production sms sending limit with Pinpoint is currently $10,000 USD

Wait - the sns_monthly_spend_limit in terraform is 30000 - this is likely where we're getting the Pinpoint "Account limit" from. But we have our "Enforced limit" set to 10000. Probably we just didn't update it when we increased our spend limit to 30000. Probably we should just set it to track the max

sastels commented 2 weeks ago

Made some new cards to break down the work (and include both staging and prod sides of the work):

cds-snc / notification-planning-core